[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 14 15:22:23 PST 2022


jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang/lib/Serialization/ASTWriter.cpp:1561
       else
         // FIXME: The path should be taken from the FileEntryRef.
         PP->Diag(SourceLocation(), diag::err_module_unable_to_hash_content)
----------------
Do you think resolving this fixme warrants separate patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137989/new/

https://reviews.llvm.org/D137989



More information about the cfe-commits mailing list