[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 14 12:58:47 PST 2022


HazardyKnusperkeks marked 3 inline comments as done.
HazardyKnusperkeks added inline comments.


================
Comment at: clang/unittests/Format/ConfigParseTest.cpp:1006
+
+TEST(FormatStyle, GetStyleWithEmptyFileName) {
+  llvm::vfs::InMemoryFileSystem FS;
----------------
owenpan wrote:
> Otherwise, the test will be skipped.
That is not true.
It will be executed, and that was the name in the beginning.

I only changed the old `FormatTest` to `ParseTest` and didn't change these 3, because I thought someone made this on purpose.

```
[ RUN      ] ParseTest.ConfigurationRoundTripTest
[       OK ] ParseTest.ConfigurationRoundTripTest (4 ms)
[----------] 7 tests from ParseTest (201 ms total)

[----------] 3 tests from FormatStyle
[ RUN      ] FormatStyle.GetStyleWithEmptyFileName
[       OK ] FormatStyle.GetStyleWithEmptyFileName (3 ms)
```


================
Comment at: clang/unittests/Format/ConfigParseTest.cpp:1013
+
+TEST(FormatStyle, GetStyleOfFile) {
+  llvm::vfs::InMemoryFileSystem FS;
----------------
owenpan wrote:
> Change `FormatStyle` to `ParseTest` here and on line 1220 below.
Discussion above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137823/new/

https://reviews.llvm.org/D137823



More information about the cfe-commits mailing list