[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

Mon Nov 14 06:23:39 PST 2022

diseraluca added a comment.

In D137246#3919795 <https://reviews.llvm.org/D137246#3919795>, @aaron.ballman wrote:

> In D137246#3911881 <https://reviews.llvm.org/D137246#3911881>, @diseraluca wrote:
>
>> I finally had some time to look into the pre-merge failure. I couldn't replicate it on my machine by following https://buildkite.com/llvm-project/premerge-checks/builds/119952#01843856-e8c7-4709-89c6-d52d0286862a .
>>
>> Looking at the log it does not seem related to the patch, I think it might be a flaky failing.
>> Is there a way to rerun the pre-merge checks?
>
> Yeah, that looks like a flaky test. You can restart CI by clicking the "Restart Build" link on the Harbormaster instance, I believe (https://reviews.llvm.org/harbormaster/build/296625/). If all else fails, you can usually rebase the patch on main and upload the new patch.
>
> LGTM!

Thank you for the explanation! I've landed this one as it seemed safe enough and testing locally brought nothing up. I'll be sure to be around to check if anything fails because of it, albeit I expect it will not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137246/new/

https://reviews.llvm.org/D137246