[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Mon Nov 14 05:42:24 PST 2022

ChuanqiXu added a comment.

In D137787#3924341 <https://reviews.llvm.org/D137787#3924341>, @Hahnfeld wrote:

>> Sorry, I don't understand well. Could you rewrite the reproducer in the style I wrote? And in what cases it works fine?
>
> Okay, let me try to restate: I can reproduce the problem in ROOT/Cling which is an *interpreter* built on top of LLVM and CLang. The moment I put the same code (basically in the style that you wrote it) into standalone Clang, all is fine and I cannot reproduce the crash. Sorry if that was confusing in the beginning, but I've tried to make this clear from the start that I cannot actually reproduce this in pure Clang.

Thanks, I got your point. But a test is really necessary here. Since it is completely possible that the problem happens in earlier steps and it only shows in this assertion. And it will be pretty bad in this case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137787/new/

https://reviews.llvm.org/D137787