[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 14 02:15:47 PST 2022


hokein added a comment.

In D137697#3924305 <https://reviews.llvm.org/D137697#3924305>, @Hahnfeld wrote:

> @hokein it seems the unit test wasn't updated for the last-minute API change, which breaks `check-all` for me. I've posted https://reviews.llvm.org/D137927, could you take a look if that change is correct?

oops, thanks, and your analysis is right! (I landed a fix in 5c4ae8a86a865e622e2c663666c0c139334b5da2 <https://reviews.llvm.org/rG5c4ae8a86a865e622e2c663666c0c139334b5da2> before reading your email, sorry).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137697/new/

https://reviews.llvm.org/D137697



More information about the cfe-commits mailing list