[PATCH] D137714: Do not merge traps in functions annotated optnone

Dan Liew via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 13 10:24:48 PST 2022


delcypher added a comment.

Other than minor issue in the test this LGTM



================
Comment at: clang/test/CodeGen/ubsan-trap-debugloc.c:11
+void bar(volatile int a) __attribute__((optnone)) {
+  // CHECK: call void @llvm.ubsantrap(i8 0){{.*}} !dbg [[LOC2:![0-9]+]]
+  // CHECK: call void @llvm.ubsantrap(i8 0){{.*}} !dbg [[LOC3:![0-9]+]]
----------------
Could you add `CHECK-LABEL: @foo` and `CHECK-LABEL: @bar` to this test? This helps make it explicit which functions in the IR we are trying to match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137714/new/

https://reviews.llvm.org/D137714



More information about the cfe-commits mailing list