[PATCH] D137874: clang/AMDGPU: Use Support's wrapper around getenv
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 11 16:18:32 PST 2022
arsenm created this revision.
arsenm added a reviewer: yaxunl.
Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added subscribers: MaskRay, wdng.
This does some extra stuff for Windows, so might as well
use it just in case.
https://reviews.llvm.org/D137874
Files:
clang/lib/Driver/ToolChains/AMDGPU.cpp
Index: clang/lib/Driver/ToolChains/AMDGPU.cpp
===================================================================
--- clang/lib/Driver/ToolChains/AMDGPU.cpp
+++ clang/lib/Driver/ToolChains/AMDGPU.cpp
@@ -20,6 +20,7 @@
#include "llvm/Support/Host.h"
#include "llvm/Support/LineIterator.h"
#include "llvm/Support/Path.h"
+#include "llvm/Support/Process.h"
#include "llvm/Support/VirtualFileSystem.h"
#include <system_error>
@@ -199,9 +200,10 @@
ROCmSearchDirs.emplace_back(RocmPathArg.str());
DoPrintROCmSearchDirs();
return ROCmSearchDirs;
- } else if (const char *RocmPathEnv = ::getenv("ROCM_PATH")) {
- if (!StringRef(RocmPathEnv).empty()) {
- ROCmSearchDirs.emplace_back(RocmPathEnv);
+ } else if (Optional<std::string> RocmPathEnv =
+ llvm::sys::Process::GetEnv("ROCM_PATH")) {
+ if (!RocmPathEnv->empty()) {
+ ROCmSearchDirs.emplace_back(std::move(*RocmPathEnv));
DoPrintROCmSearchDirs();
return ROCmSearchDirs;
}
@@ -374,8 +376,9 @@
if (!RocmDeviceLibPathArg.empty())
LibDevicePath = RocmDeviceLibPathArg[RocmDeviceLibPathArg.size() - 1];
- else if (const char *LibPathEnv = ::getenv("HIP_DEVICE_LIB_PATH"))
- LibDevicePath = LibPathEnv;
+ else if (Optional<std::string> LibPathEnv =
+ llvm::sys::Process::GetEnv("HIP_DEVICE_LIB_PATH"))
+ LibDevicePath = std::move(*LibPathEnv);
auto &FS = D.getVFS();
if (!LibDevicePath.empty()) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137874.474885.patch
Type: text/x-patch
Size: 1453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221112/28953e95/attachment.bin>
More information about the cfe-commits
mailing list