[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

Fri Nov 11 11:27:18 PST 2022

erichkeane added a comment.

I think this is a move in the right direction, and generally is probably pretty close.  The new bool for `ArgsHasSubstitutionFailure` isn't something I get the need for yet though.

we also need release notes.

================
Comment at: clang/include/clang/AST/ExprConcepts.h:103

+  bool hasSubstitutionFailureInArgs() const {
+    return ArgsHasSubstitutionFailure;
----------------
Does this really belong here instead of as a part of the ConceptSpecializationDecl?

================
Comment at: clang/include/clang/AST/ExprConcepts.h:159
+  // todo: add doc ?
+struct SubstitutionDiagnostic {
+  StringRef SubstitutedEntity;
----------------
I had a previous patch at something else where I was moving toward doing this change, so I think this is probably something inevitable.  

However, I'm having a tough time splitting this patch mentally between the 'fix' and the infrastructure changes needed.  A part of me thinks we should split this patch a bit in that direction.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137712/new/

https://reviews.llvm.org/D137712