[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added inline comments.


================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:447
+        SmallString<128> CanonicalPath = FE.getNameAsRequested();
+        ModMapInfo.canonicalizeModuleMapPath(CanonicalPath);
+        MD.ModuleMapFileDeps.emplace_back(CanonicalPath);
----------------
Was this canonicalization necessary? If this is needed can we do it in the implicit module build so that it is serialized with the correct path? That seems better for both stability of the implicit module build and avoids re-canonicalizing the path every time it is scanned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135636/new/

https://reviews.llvm.org/D135636