[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 10 18:12:49 PST 2022


ChuanqiXu added a comment.

I think it might be necessary/better to add a test for this. Otherwise, it looks not good to change this.

> This fixes the assertion for a downstream case in ROOT/Cling with the involvement of modules. If anyone has ideas how to test this, please let me know...

Yeah, I know, this is pretty hard. And it would generally take a lot of time doing it. The method I used is to:

- preprocess the failure files
- Remove the unnecessary information, like a lot of line markers.
- reduce them - repeating remove some part of the codes and see if the crash exists
- Rename variables (if need)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137787/new/

https://reviews.llvm.org/D137787



More information about the cfe-commits mailing list