[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function
Chris Bowler via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 10 10:22:43 PST 2022
cebowleratibm added a comment.
I believe the fix for a52d151f9dde7 inadvertently exposed a code path where by the linkage of a static local of a static function, which would otherwise return LinkageInfo::none() may now return VisibleNoLinkage depending on the incoming computation argument.
I don't think a static local of a function with no linkage should ever return VisibleNoLinkage so I've added the appropriate guard such that the linkage evaluation with return no linkage regardless of the computation argument.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128223/new/
https://reviews.llvm.org/D128223
More information about the cfe-commits
mailing list