[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 10 09:35:08 PST 2022


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM to me with those formatting fixes.



================
Comment at: clang/test/CodeGen/builtins-elementwise-math.c:337
+void test_builtin_elementwise_cos(float f1, float f2, double d1, double d2,
+  float4 vf1, float4 vf2) {
+  // CHECK-LABEL: define void @test_builtin_elementwise_cos(
----------------
Line these up with the start of the arguments on the previous line.


================
Comment at: clang/test/CodeGen/builtins-elementwise-math.c:385
+void test_builtin_elementwise_sin(float f1, float f2, double d1, double d2,
+  float4 vf1, float4 vf2) {
+  // CHECK-LABEL: define void @test_builtin_elementwise_sin(
----------------
Same


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135011/new/

https://reviews.llvm.org/D135011



More information about the cfe-commits mailing list