[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.
    Haojian Wu via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Thu Nov 10 06:42:24 PST 2022
    
    
  
hokein marked 2 inline comments as done.
hokein added inline comments.
================
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:84
+        Out->IWYUExportBy[IncludedHeader->getUniqueID()].push_back(
+            save(SM.getFileEntryForID(Top.SeenAtFile)->tryGetRealPathName()));
+      // main-file #include with export pragma should never be removed.
----------------
kadircet wrote:
> i guess we should just use `Top.FullPath` here instead?
oops, I added the FullPath, but forgot to update the usage here.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137319/new/
https://reviews.llvm.org/D137319
    
    
More information about the cfe-commits
mailing list