[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

Tom Praschan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 9 14:04:12 PST 2022


tom-anders added a comment.

Hmm I added the test for the flag to Sema, but now we kinda have the same test case duplicated in sema and clangd tests - I guess for clangd we now actually only have to test that the SnippetSuffix is cleared when FunctionCanBeCall is true, but I don't see an easy way to somehow inject fake Sema results into CodeComplete.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137040/new/

https://reviews.llvm.org/D137040



More information about the cfe-commits mailing list