[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

> ...we expect template params to be fully qualified when comparing them for simple template names

So lldb is not inspecting the AST, they're doing reflection (of a sort) on the pretty printed names? Or am I misunderstanding something?



================
Comment at: clang/include/clang/AST/PrettyPrinter.h:134
+  /// When SuppressScope is true, do not apply it to template parameters.
+  unsigned NoSuppressTemplateParamsScope : 1;
+
----------------
I think this should be expressed in the positive rather than in the negative (`SuppressTemplateParamScope`) so it's consistent with the rest of the options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137583/new/

https://reviews.llvm.org/D137583