[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 9 08:18:50 PST 2022


tbaeder added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:2653
+  APFloat::opStatus St = Result.convertFromAPInt(Value, Value.isSigned(), RM);
+  return checkFloatingPointResult(Info, E, St);
 }
----------------
tbaeder wrote:
> `SrcType` was already unused before, but not so is `FPO`.
//now// so is `FPO`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137719/new/

https://reviews.llvm.org/D137719



More information about the cfe-commits mailing list