[PATCH] D137650: [clangd] Implement hover for string literals

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/Hover.cpp:816
+  if (llvm::isa<StringLiteral>(E)) {
+    HoverInfo::PrintedType PT;
+    PT.Type = E->getType().getAsString(PP);
----------------
can you extract this into a function, similar to the cases below?


================
Comment at: clang-tools-extra/clangd/Hover.cpp:819
+    HI.Type = PT;
+    HI.Name = "String Literal";
+    return HI;
----------------
i think it's a good idea to also include the size here (e.g. L"XYZ", would be 8 bytes).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137650/new/

https://reviews.llvm.org/D137650