[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 9 01:34:46 PST 2022


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/include-cleaner/lib/HTMLReport.cpp:243
+    for (Header H : T.Providers) {
+      OS << "Candidate: ";
+      escapeString(llvm::to_string(H));
----------------
It seems noisy to print it even there is only one candidate, maybe exclude it if there is only one candidate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137677/new/

https://reviews.llvm.org/D137677



More information about the cfe-commits mailing list