[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

Noah Goldstein via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 23:09:36 PST 2022


goldstein.w.n added a comment.

In D137181#3916547 <https://reviews.llvm.org/D137181#3916547>, @owenpan wrote:

> In D137181#3916521 <https://reviews.llvm.org/D137181#3916521>, @goldstein.w.n wrote:
>
>> I think we can remove the places I set `InitialPPLevel` and `OldPPLevel` but anything else I remove causes at least one test to fail.
>>
>> What did you do? Just set `PPLevel = PPBranchLevel`?
>
> Yes, if there is a header guard. Otherwise, set `PPLevel` to `PPBranchLevel + 1`.

That fails alot of the tests for me.

I have a patch attached (applyable on this) maybe you did something different?F25244239: v1-0001-Remove-all-other-defs.patch <https://reviews.llvm.org/F25244239>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137181/new/

https://reviews.llvm.org/D137181



More information about the cfe-commits mailing list