[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

[Phoebe Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: llvm/include/llvm/Support/X86TargetParser.def:94
+X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,            "znver4")
+X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST,   "sierraforest")
+X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS,  "graniterapids")
----------------
FreddyYe wrote:
> FreddyYe wrote:
> > FYI: gcc is going to land the [[ https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603547.html | sierraforest patch ]]. They are going to add such E-core based CPUs to CPU_TYPE list but not this one, like the previous atom series e.g. tremont, silvermont and so on. It's functionally correct, so I'm ok to this change. WDYT
> > FYI: gcc is going to land the [[ https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603547.html | sierraforest patch ]]. They are going to add such E-core based CPUs to CPU_TYPE list but not this one, like the previous atom series e.g. tremont, silvermont and so on. It's functionally correct, so I'm ok to this change. WDYT
> 
> ping.
Is this to match with GCC?


================
Comment at: llvm/lib/Support/X86TargetParser.cpp:389
+  // Graniterapids microarchitecture based processors.
+  { {"graniterapids"}, CK_Graniterapids, FEATURE_AVX512VP2INTERSECT, FeaturesGraniteRapids },
   // Knights Landing processor.
----------------
Is `VP2INTERSECT` supported by `graniterapids`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137153/new/

https://reviews.llvm.org/D137153