[PATCH] D137674: [clangd] Make system-include-extractor.test more resilient in the face of paths with special characters

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 14:45:16 PST 2022


nridge created this revision.
nridge added a reviewer: ayzhao.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137674

Files:
  clang-tools-extra/clangd/test/system-include-extractor.test


Index: clang-tools-extra/clangd/test/system-include-extractor.test
===================================================================
--- clang-tools-extra/clangd/test/system-include-extractor.test
+++ clang-tools-extra/clangd/test/system-include-extractor.test
@@ -63,7 +63,9 @@
 # CHECK:   "method": "textDocument/publishDiagnostics",
 # CHECK-NEXT:   "params": {
 # CHECK-NEXT:     "diagnostics": [],
-# CHECK-NEXT:     "uri": "file://INPUT_DIR/the-file.cpp",
+# Double-check that the diagnostics pertain to the intended file.
+# We don't match the path portion exactly to avoid issues around URL escaping.
+# CHECK-NEXT:     "uri": "file://{{.*}}/the-file.cpp",
 ---
 {"jsonrpc":"2.0","id":10000,"method":"shutdown"}
 ---


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137674.474093.patch
Type: text/x-patch
Size: 727 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221108/c8e98524/attachment.bin>


More information about the cfe-commits mailing list