[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

Ben Barham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 12:58:31 PST 2022


bnbarham added inline comments.


================
Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4
+  'case-sensitive': false,
+  'overlay-relative': true,
+  'root-relative': 'yaml-dir',
----------------
bnbarham wrote:
> I'd prefer a test without `overlay-relative` set to make it clear they don't depend on each other.
There's also unit tests in `llvm/unittests/Support/VirtualFileSystemTest.cpp` that you could add to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137473/new/

https://reviews.llvm.org/D137473



More information about the cfe-commits mailing list