[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

Tom Praschan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 10:54:20 PST 2022


tom-anders accepted this revision.
tom-anders added a comment.
This revision is now accepted and ready to land.

Would be cool if in the future we could instead transform something like

  using namespace std;
  int main() {
     auto t = 5ms;
  }

into

  using namespace std::chrono_literals;
  int main() {
     auto t = 5ms;
  }

But I think your fix certainly improved the behavior for now, so LGTM!



================
Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:253
+    )cpp"},
+      {// Does qualify user-defined literals
+       R"cpp(
----------------





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137550/new/

https://reviews.llvm.org/D137550



More information about the cfe-commits mailing list