[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

Tue Nov 8 07:34:59 PST 2022

kadircet added inline comments.

================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:25
 namespace clang::include_cleaner {
 namespace {
+using DeclCallback =
----------------
tschuett wrote:
> There is a cuter way to use anonymous namespaces:
> https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
sorry missed that one, were you referring to definitions of methods? because AFAICT there isn't anything else inside this anon namespace that i can declare static in a named-namespace instead.
if that's the case, i don't think it's actually common in the codebase to define your methods out-of-line when the whole class is an implementation detail.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135859/new/

https://reviews.llvm.org/D135859