[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 8 00:10:54 PST 2022


owenpan added a comment.

In D137181#3914083 <https://reviews.llvm.org/D137181#3914083>, @goldstein.w.n wrote:

> In D137181#3914066 <https://reviews.llvm.org/D137181#3914066>, @owenpan wrote:
>
>> @goldstein.w.n do you need to modify MacroCallReconstructor.cpp, Macros.h, and MacroCallReconstructorTest.cpp? Leaving them out wouldn't break any existing tests.
>
> Hi, sorry to go mia all day. We can't drop `PPLevel` from `MacroCallReconstructor` because we need it for the `createUnwrappedLine` MacroCallReconstructor.cpp:L66.

Why would you need it for `createUnwrappedLine`? Can you add test cases for the requirement? Removing all the changes to `MacroCallReconstructor` doesn't fail any existing and new tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137181/new/

https://reviews.llvm.org/D137181



More information about the cfe-commits mailing list