[PATCH] D136565: [clang] Instantiate alias templates with sugar

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 7 19:12:53 PST 2022


Given the broad impact of this in our code I'm inclined to revert the patch
to unblock us. The test case I have so far is still too large, but I hope
to get something shareable tomorrow.

On Tue, 8 Nov 2022, 04:03 Matheus Izvekov via Phabricator, <
reviews at reviews.llvm.org> wrote:

> mizvekov added a comment.
>
> @alexfh Thanks!
>
> While there is a huge increase in the amount of UsingTypes, it seems the
> total amount is still reasonable and does not explain the perf hit.
>
> Perhaps this is a case of bad hashing and they are all falling into the
> same bucket?
>
> cc @sam.mcall for awareness of UsingType issue.
> It may be some very simple problem, I just can't even look at the code
> right now.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D136565/new/
>
> https://reviews.llvm.org/D136565
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221108/21820dab/attachment.html>


More information about the cfe-commits mailing list