[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

[Hans Wennborg via Phabricator via cfe-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm with nits



================
Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:47
+// MESSAGELEN: 0x{{.+}} | LF_BUILDINFO [size = {{.+}}]
+// MESSAGELEN-NOT:          0x{{.+}}: `"{{.+}}-fmessage-length=
----------------
could this be just
MESSAGELEN-NOT: -fmessage-length
?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:911
       continue;
+    // Skip fmessage-length for reproduciability
+    if (Arg.startswith("-fmessage-length"))
----------------
nit: Period at the end (though I know we're not super consistent about this).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137322/new/

https://reviews.llvm.org/D137322