[PATCH] D137531: [clang] Fix the GitHub issue #58674

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a reviewer: clang-language-wg.
aaron.ballman added a comment.

FWIW, it'd help reviewers out if you would use a more descriptive title for the patch than just the GitHub issue number (it's easier for us to keep reviews straight when they have more concrete titles). I made a quick pass over this review and spotted some tiny nits, but I need to give it a more thorough review when I have some spare cycles.



================
Comment at: clang/lib/Sema/SemaExpr.cpp:2708-2710
+      if (R.isSingleResult() && (isa<FieldDecl>(R.getFoundDecl()) ||
+                                 isa<IndirectFieldDecl>(R.getFoundDecl()) ||
+                                 isa<MSPropertyDecl>(R.getFoundDecl()))) {
----------------
We can simplify this since we're in the area anyway.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:2711-2715
+        if (auto Class = dyn_cast_or_null<CXXRecordDecl>(
+                (*R.begin())->getDeclContext())) {
+          for (auto Curr = S->getLookupEntity(); Curr && !Curr->isFileContext();
+               Curr = Curr->getParent()) {
+            if (auto ThisClass = dyn_cast_or_null<CXXRecordDecl>(Curr)) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137531/new/

https://reviews.llvm.org/D137531