[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

John Ericson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 7 05:37:18 PST 2022

Previous message: [clang] 39dbfa7 - Revert "Only add targetFallback if target is not in defined in current product"
Next message: [PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Ericson2314 added a comment.

This change introduces a lot of conditional code, that is not necessary. This change also uses `CLANG_` outside `clang/` which is messy. and confusing. Please clean up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136809/new/

https://reviews.llvm.org/D136809

Previous message: [clang] 39dbfa7 - Revert "Only add targetFallback if target is not in defined in current product"
Next message: [PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list