[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics
Lu Weining via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 7 03:33:36 PST 2022
SixWeining accepted this revision.
SixWeining added a comment.
This revision is now accepted and ready to land.
LGTM except 2 nits. And let's wait others.
================
Comment at: clang/lib/Basic/Targets/LoongArch.cpp:174
+ const std::vector<std::string> &FeaturesVec) const {
+
+ if (getTriple().getArch() == llvm::Triple::loongarch64)
----------------
Delete blank line.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:3677
+ CallExpr *TheCall) {
+
+ switch (BuiltinID) {
----------------
Delete blank line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137316/new/
https://reviews.llvm.org/D137316
More information about the cfe-commits
mailing list