[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 6 18:54:37 PST 2022


MaskRay added subscribers: Bdragon28, jhibbits, dim.
MaskRay added a comment.

In D137511#3911052 <https://reviews.llvm.org/D137511#3911052>, @thesamesam wrote:

> This needs to go in Breaking Changes in the release notes, not least so we can link to it when updating upstreams.
>
> What do you mean by "while the darwin support has been removed from llvm-project."? I don't think that's the case, if you mean that LLVM.org's LLVM lacks support for Darwin.

Clarified it to "The darwin ppc support has been removed from llvm-project."

In D137511#3910880 <https://reviews.llvm.org/D137511#3910880>, @q66 wrote:

> The `__ppc__` macro should get the same treatment. That said, I believe there are instances of both macros being used across the LLVM codebase, and those cases are valid, so that should also be updated (one instance i know of is the limits header of libcxx, there are likely more)

`__ppc__` is defined for FreeBSD in GCC, so perhaps we can make a separate change making `__ppc__` only defined for FreeBSD (@dim @Bdragon28 @jhibbits).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137511/new/

https://reviews.llvm.org/D137511



More information about the cfe-commits mailing list