[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 5 20:16:45 PDT 2022


junaire added a comment.

In D137494#3910500 <https://reviews.llvm.org/D137494#3910500>, @v1nh1shungry wrote:

> @tom-anders Thank you for reviewing!
>
> I tried adding a test but I don't know how to run the tests.
>
> And I just found that operators declared in a class context are already handled in the existing version, but user-defined literals are not, so I rewrote the comments.

I guess that's `ninja check-clangd`?



================
Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:236
+      }
+      using namespace n^s;
+      int main() {
----------------
is this a typo?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137494/new/

https://reviews.llvm.org/D137494



More information about the cfe-commits mailing list