[PATCH] D137488: [clang][Interp] Array initialization via string literal

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 5 14:09:59 PDT 2022


tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1138
+    // FIXME: There is a certain code duplication between here
+    //   and Porgram::createGlobalString().
+    const size_t CharWidth = SL->getCharByteWidth();
----------------
tschuett wrote:
> tschuett wrote:
> > Program
> Probably I misunderstood something. It says:
> ```
> Porgram::createGlobalString
> ```
> I would expected it to start with **Program** and not **Porgram**.
> 
Yep, I fixed it locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137488/new/

https://reviews.llvm.org/D137488



More information about the cfe-commits mailing list