[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 5 08:14:41 PDT 2022


thakis added inline comments.


================
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:25
+
+  file(GLOB cpp_files "${output_dir}/${filename}*.cpp")
+
----------------
Can we list them? We try not to use globs in cmakelists.txt files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136283/new/

https://reviews.llvm.org/D136283



More information about the cfe-commits mailing list