[PATCH] D137475: Explicitly initialize opaque pointer mode when -fthinlto-index is used

[Nikita Popov via Phabricator via cfe-commits]

nikic added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:1112
+    // mixing opaque pointers and typed pointers bitcode files.
+    VMContext->setOpaquePointers(CI.getCodeGenOpts().OpaquePointers);
+
----------------
I think it would be fine to always do this, not just for the ThinLTO case.


================
Comment at: clang/test/CodeGen/thinlto-opaque-typed-mix.ll:14
+; RUN:   -fthinlto-index=%t/typed.bc.thinlto.bc
+; RUN: false
+
----------------
What's the `false` doing here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137475/new/

https://reviews.llvm.org/D137475