[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

[zhouyizhou via Phabricator via cfe-commits]

zhouyizhou added a comment.

In D119493#3403458 <https://reviews.llvm.org/D119493#3403458>, @efriedma wrote:

> 

Thank Eli for your comment and guidance and sorry to have carelessly neglected your comment for 7 months!

> I'm not sure this is the right fix. If we were handling the pseudo-destructor correctly, I would expect the following to compile successfully:
>
>   typedef bool Var;
>   constexpr bool foobool() {
>   	return (bool().Var::~Var(), false); 
>   }

Yes, g++ can compile above code successfully, while we can't.
I am going to try to fix above (I am a beginner who eager to learn ;-)

Cheers
Zhouyi


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119493/new/

https://reviews.llvm.org/D119493