[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

Fri Nov 4 16:27:03 PDT 2022

ronlieb added a comment.

[AMD Official Use Only - General]

Please look into AMDGPU bot fail
https://lab.llvm.org/buildbot/#/builders/193/builds/21319

Get Outlook for iOShttps://aka.ms/o0ukef

________________________________

From: Jennifer Yu via Phabricator <reviews at reviews.llvm.org>
Sent: Friday, November 4, 2022 5:40:19 PM
To: jennifer.yu at intel.com <jennifer.yu at intel.com>; abhinav.gaba at intel.com <abhinav.gaba at intel.com>; a.bataev at hotmail.com <a.bataev at hotmail.com>; michael.p.rice at intel.com <michael.p.rice at intel.com>; jdoerfert at anl.gov <jdoerfert at anl.gov>
Cc: i at tianshilei.me <i at tianshilei.me>; openmp-commits at lists.llvm.org <openmp-commits at lists.llvm.org>; stefomeister at gmail.com <stefomeister at gmail.com>; cfe-commits at lists.llvm.org <cfe-commits at lists.llvm.org>; Pandey, Amit <Amit.Pandey at amd.com>; Islam, Saiyedul <Saiyedul.Islam at amd.com>; jeffrey.sandoval at hpe.com <jeffrey.sandoval at hpe.com>; abidmuslim at gmail.com <abidmuslim at gmail.com>; mpique at icloud.com <mpique at icloud.com>; Lieberman, Ron <Ron.Lieberman at amd.com>; greg63706 at gmail.com <greg63706 at gmail.com>; kkwli0 at gmail.com <kkwli0 at gmail.com>; zhang.guansong at gmail.com <zhang.guansong at gmail.com>; ravi.narayanaswamy at intel.com <ravi.narayanaswamy at intel.com>; kevin.sala at bsc.es <kevin.sala at bsc.es>; jdenny.ornl at gmail.com <jdenny.ornl at gmail.com>; balaji-sankar-naga-sai-sandeep.kosuri at hpe.com <balaji-sankar-naga-sai-sandeep.kosuri at hpe.com>; misono.tomohiro at fujitsu.com <misono.tomohiro at fujitsu.com>; sunil.shrestha at hpe.com <sunil.shrestha at hpe.com>; michael.hliao at gmail.com <michael.hliao at gmail.com>; Balasubrmanian, Vignesh <Vignesh.Balasubrmanian at amd.com>; chichun.chen at hpe.com <chichun.chen at hpe.com>; Kumar N, Bhuvanendra <Bhuvanendra.KumarN at amd.com>; lin32 at llnl.gov <lin32 at llnl.gov>; xw111luoye at gmail.com <xw111luoye at gmail.com>; Tomar, Sourabh Singh <SourabhSingh.Tomar at amd.com>; liao6 at llnl.gov <liao6 at llnl.gov>; sara.royuela at bsc.es <sara.royuela at bsc.es>; deepak.eachempati at hpe.com <deepak.eachempati at hpe.com>; jatin.bhateja at gmail.com <jatin.bhateja at gmail.com>; 1135831309 at qq.com <1135831309 at qq.com>; gandhi21299 at gmail.com <gandhi21299 at gmail.com>; tbaeder at redhat.com <tbaeder at redhat.com>; mlekena at skidmore.edu <mlekena at skidmore.edu>; blitzrakete at gmail.com <blitzrakete at gmail.com>; shenhan at google.com <shenhan at google.com>; david.green at arm.com <david.green at arm.com>; Song, Ruiling <Ruiling.Song at amd.com>
Subject: [PATCH] D137313 <https://reviews.llvm.org/D137313>: [NFC] Remove redundant loads when has_device_addr is used.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

jyu2 closed this revision.
jyu2 added a comment.

de14befa7730093ff3d46c7628fa1084f251e98d <https://reviews.llvm.org/rGde14befa7730093ff3d46c7628fa1084f251e98d> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FrGde14befa7730093ff3d46c7628fa1084f251e98d&data=05%7C01%7Cron.lieberman%40amd.com%7C89e7e812ba444904677f08dabeb58de0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638031984301236587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=91XJgV2YZU9jqHYiXbrS4d5t95xt2Bro%2FwEMG6SpUY0%3D&reserved=0

Repository:

  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION

  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD137313%2Fnew%2F&data=05%7C01%7Cron.lieberman%40amd.com%7C89e7e812ba444904677f08dabeb58de0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638031984301236587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o9eGJWg86IGPzt2G4SlgX6VTxpoWRlAEhb2TBO%2BcGTw%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD137313&data=05%7C01%7Cron.lieberman%40amd.com%7C89e7e812ba444904677f08dabeb58de0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638031984301236587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VPD4ootaA99%2FEMcRn34ONBJTzQYWvfTqqh2ErRLrSaA%3D&reserved=0

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137313/new/

https://reviews.llvm.org/D137313