[PATCH] D135411: Add generic KCFI operand bundle lowering

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:42
+namespace {
+class KCFIDiagnosticInfo : public DiagnosticInfo {
+  const Twine &Msg;
----------------
If you look at existing DiagnosticInfo subclasses, they are mostly named `DiagnosticInfo*`


================
Comment at: llvm/test/Transforms/KCFI/kcfi-patchable-function-prefix.ll:1
+; RUN: not opt -S -passes=kcfi < %s 2>&1 | FileCheck %s
+
----------------
You can omit `< `


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135411/new/

https://reviews.llvm.org/D135411