[PATCH] D136554: Implement CWG2631

Fri Nov 4 13:56:43 PDT 2022

abrachet added a comment.

In D136554#3909198 <https://reviews.llvm.org/D136554#3909198>, @cor3ntin wrote:

> In D136554#3909196 <https://reviews.llvm.org/D136554#3909196>, @abrachet wrote:
>
>> Hi, we're hitting an assertion failure after this patch
>>
>>   llvm-project/clang/lib/Sema/SemaDecl.cpp:15589: Decl *clang::Sema::ActOnFinishFunctionBody(Decl *, Stmt *, bool): Assertion `MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking"' failed.
>>
>> Here is a reproducer https://storage.googleapis.com/fuchsia-artifacts/builds/8798414214460746113/build-debug/clang-crashreports/symbol_server_unittest-48a521.cpp and https://storage.googleapis.com/fuchsia-artifacts/builds/8798414214460746113/build-debug/clang-crashreports/symbol_server_unittest-48a521.sh unfortunately creduce was taking too long before I gave up on it, so sorry it hasn't been reduced at all.
>>
>> I've verified that with this reverted the problem goes away. Could we revert unless there is a quick fix forward?
>
> Thanks for reporting that. Did you tried a more recent commit? We fixed that issue today. (Along with z couple additional issues)

Yes, this happens at HEAD (currently ba65584d <https://github.com/llvm/llvm-project/commit/ba65584d1545951ce958ea5729692374055d6b9f>)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136554/new/

https://reviews.llvm.org/D136554