[PATCH] D136554: Implement CWG2631

[Alex Brachet via Phabricator via cfe-commits]

abrachet added a comment.

Hi, we're hitting an assertion failure after this patch

  llvm-project/clang/lib/Sema/SemaDecl.cpp:15589: Decl *clang::Sema::ActOnFinishFunctionBody(Decl *, Stmt *, bool): Assertion `MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking"' failed.

Here is a reproducer https://storage.googleapis.com/fuchsia-artifacts/builds/8798414214460746113/build-debug/clang-crashreports/symbol_server_unittest-48a521.cpp and https://storage.googleapis.com/fuchsia-artifacts/builds/8798414214460746113/build-debug/clang-crashreports/symbol_server_unittest-48a521.sh unfortunately creduce was taking too long before I gave up on it, so sorry it hasn't been reduced at all.

I've verified that with this reverted the problem goes away. Could we revert unless there is a quick fix forward?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136554/new/

https://reviews.llvm.org/D136554