[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

The issue that caused this issue was fix by the fix in https://reviews.llvm.org/rGa92cf5a5a0cd01145f8db2ae09334a8b43a1271b , from the clang-format perspective I don't really feel we need to revisit bringing in these libraries.

I think I proved that moving everything to lib/Basic isn't always the best way to go, if keeping the dependencies low (if speed of building the tools is of concern, which it is for me at least)

Ultimately if there is a better way for this to be structured, it needs to be handled by someone who is the owner of clang/Basic and/or llvm/Support, I don't feel like our team is in the best position to drive that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90121/new/

https://reviews.llvm.org/D90121