[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel marked 2 inline comments as done.
ymandel added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:365
     if (IsSet1 == nullptr)
-      return true;
+      return IsSet2 ? ComparisonStatus::Same : ComparisonStatus::Different;
 
----------------
sgatev wrote:
> Why is it same if `IsSet1` is null and `IsSet2` isn't null?
Fixed. that was a mistake.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1185
-
-  bool compareEquivalent(QualType Type, const Value &Val1,
-                         const Environment &Env1, const Value &Val2,
----------------
sgatev wrote:
> Why remove this? It's not the same as the default implementation, right?
Correct -- that was a mistake (I think my first version had a sound default, which I later put back as unsound to keep this NFC).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137334/new/

https://reviews.llvm.org/D137334