[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 3 09:44:54 PDT 2022


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

Seems fine, though looking at `llvm::X86::CPUKind`, why do you choose `llvm::X86::CK_PentiumPro` as the lower bounds? Surely `llvm::X86::CK_Pentium2` doesn't support CET?

Does the backend already have an equivalent CPU target check that could be reused by clang?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137317/new/

https://reviews.llvm.org/D137317



More information about the cfe-commits mailing list