[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

Thu Nov 3 05:00:58 PDT 2022

jhuber6 added a comment.

In D136796#3904512 <https://reviews.llvm.org/D136796#3904512>, @jhenderson wrote:

> In D136796#3903393 <https://reviews.llvm.org/D136796#3903393>, @jhuber6 wrote:
>
>> Is this good to land now?
>
> The LLVM community practice is to wait a week between pings unless there's something urgent (and if something is urgent, please say so).
>
> Aside from the clang bit of the patch, this seems good to me, but it would be worth another person involved with offloading to give the final thumbs up.

I could precommit that part if it would make it cleaner, but since this patch changes the extract routine to handle relocatable objects we need to filter those out of the input since the linker wrapper can't handle them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136796/new/

https://reviews.llvm.org/D136796