[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas
Pierre van Houtryve via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 3 02:05:42 PDT 2022
Pierre-vh added inline comments.
================
Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300
+ ParseGNUAttributes(Attr, nullptr, &D);
+ } else if (Tok.is(tok::kw___noinline__)) {
+ IdentifierInfo *AttrName = Tok.getIdentifierInfo();
----------------
aaron.ballman wrote:
> Any other keyword attributes that are missing?
>
> `alignas`/`_Alignas`
> `__forceinline`
> `__cdecl`/`__stdcall`/etc
>
I'm not too familiar with how those attributes work yet, so maybe there's more to handle but I don't have any concrete example of it being an issue and would rather not touch those unless needed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137251/new/
https://reviews.llvm.org/D137251
More information about the cfe-commits
mailing list