[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 2 14:25:59 PDT 2022


cor3ntin added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:107-111
+    if (const auto *BD = dyn_cast<BindingDecl>(Decl))
+      VD = dyn_cast_if_present<VarDecl>(BD->getDecomposedDecl());
+    else
+      VD = dyn_cast<VarDecl>(Decl);
+    if (VD) {
----------------
aaron.ballman wrote:
> cor3ntin wrote:
> > Note that https://reviews.llvm.org/D137244 introduces a utility to do that, but i''d rather avoid having to many dependencies between these patches. 
> So the plan is to land this change, then in D137244 change this usage to the helper function introduced by that patch?
Yup, i think this would be a good order of operation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137172/new/

https://reviews.llvm.org/D137172



More information about the cfe-commits mailing list