[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

[Amara Emerson via Phabricator via cfe-commits]

aemerson added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7218-7219
+      CmdArgs.push_back("-global-isel=1");
+      CmdArgs.push_back("-mllvm");
+      CmdArgs.push_back("-global-isel-abort=0");
+    }
----------------
arsenm wrote:
> Why abort=0? I can understand abort=1 or 2
Abort=1 would mean the compiler crashes on fallback, and `2` would mean we emit diagnostics, neither of which we want for an on-by-default configuration.


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:388
+                             options::OPT_fno_global_isel);
+    if (!A || !A->getOption().matches(options::OPT_fno_global_isel)) {
       CmdArgs.push_back("-mllvm");
----------------
arsenm wrote:
> Actually I'm confused why we're duplicating this logic in both these places 
This one is for adding linker args which we need for LTO builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137269/new/

https://reviews.llvm.org/D137269