[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

Wed Nov 2 10:26:06 PDT 2022

abrachet added a comment.

In D120175#3902789 <https://reviews.llvm.org/D120175#3902789>, @thakis wrote:

> I noticed that when using `-fcrash-diagnostics=all` and the linker crashes, clang creates both preprocessor and linker repros:
>
>   clang: note: diagnostic msg: /var/folders/w6/wpbtszrs7jl9dc9l5qtdkvg00000gn/T/main-241332.c
>   clang: note: diagnostic msg: /var/folders/w6/wpbtszrs7jl9dc9l5qtdkvg00000gn/T/linker-crash-945b07.tar
>   clang: note: diagnostic msg: /var/folders/w6/wpbtszrs7jl9dc9l5qtdkvg00000gn/T/main-241332.sh
>
> Is that intentional? I would've expected to only get the linker repro when the linker crashes.

I didn't really make a conscious decision one way or the other. I guess reproing all jobs leading to a crash somewhat makes sense, though it also doesn't seem that helpful to get the preprocessed source file. I'll send out a patch to fix this

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120175/new/

https://reviews.llvm.org/D120175