[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

Wed Nov 2 03:53:54 PDT 2022

tom-anders added a comment.

In D136925#3901509 <https://reviews.llvm.org/D136925#3901509>, @nridge wrote:

> Thanks!
>
> I don't think we need this much detail in the commit message; I think after the first line it would be sufficient to say:
>
>   Fixes https://github.com/clangd/clangd/issues/1082
>   See the issue for disk/memory usage measurements
>
> (Note also that "Fixes <issue>" triggers the github issue to be closed when the commit is merged.)
>
> I forget whether you have commit access -- let me know if you need me to merge the patch for you.

Yep, I do have access. I adjusted the message and pushed this, but the corresponding Github issue is not closed automatically because I don't have the necessary permisions (I think we already hat that problem in another patch)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136925/new/

https://reviews.llvm.org/D136925