[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 2 01:37:27 PDT 2022
nridge added a comment.
The test added in the previous patch, `CompletionTest.Enums`, needs to be updated to reflect this change (`Scoped::Clangd3` now appears as a completion).
================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2136
+ if (llvm::isa<clang::EnumDecl>(ND.getDeclContext()))
+ return true;
----------------
Why remove the `(InTopLevelScope(*EnumDecl) || InClassScope(*EnumDecl))` part?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137104/new/
https://reviews.llvm.org/D137104
More information about the cfe-commits
mailing list